Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update accessibility-statement.html.erb #778

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Update accessibility-statement.html.erb #778

merged 1 commit into from
Nov 5, 2024

Conversation

alanmaddrell
Copy link
Contributor

Making Antonia's suggested changes to consolidate a heading and fix inconsistent hyphenation

@alanmaddrell
Update accessibility-statement.html.erb
43f74b5 
Making Antonia's suggested changes to consolidate a heading and fix inconsistent hyphenation
@alanmaddrell
Copy link
Contributor Author

https://payments-platform.atlassian.net/browse/PP-12053

alexbishop1
alexbishop1 reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@alexbishop1 alexbishop1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the last updated date be updated? Or do we think it’s fine to leave it because it’s a non-substantive change?

@alanmaddrell
Copy link
Contributor Author

I'd be content to leave the date as is - same convention with minor changes to GOV.UK content, for example

alexbishop1
alexbishop1 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@alexbishop1 alexbishop1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems fine then.

@alanmaddrell alanmaddrell merged commit 62cac41 into main Nov 5, 2024
4 checks passed
@alanmaddrell alanmaddrell deleted the alanmaddrell-patch-6 branch November 5, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbishop1 alexbishop1 alexbishop1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanmaddrell @alexbishop1